Demo Project

 
Quick Search:

DEMO-9 Join/Replace Changes.

Binod PGBhavanishankar, torarnv.
Patch: pasted.patch.
+ Summary of changes.
-----------------

1. RFC 3891 and 3911 are implemented. Session Targetting based on Join/Replace is implemented as per JSR 289. The changes are applicable
only to UA and not to Proxy.
2. 3911: An incoming request to the server will contain Join header with the callid/fromtag/totag of the call it want to join. Sailfin will make sure that the session of the joining request is added to the SAS of the session specified by the Join Header.
3. 3891: Same as 2 except that the header is Repaces and not Join. Main difference is the ability to specify the early-flag.
4. Both RFCs talk about authentication requirements. My thinking is that with the current digest auth support, the requirements can be met by the application.
5. SipSessionsUtil.getCorrespondingSession is implemented.
6. SAS.getApplicationName is implemented (it was a simple change).
7. For 3911, the RFC explains how the original request will be terminated. My thinking is that the termination will be done by the
application and not by the container. Thats the reason why 289 have the new SipSessionsUtil.getCorrespondingSession api.
8. The request coming in to the container with Join/Replace will not have fragment-id. So, to searching dialog is a problem. Would join/rep
lace be applicable in case of spiralling? probably not. Let me know, if there is a way to introduce fid in Join/Replace requests.
10. I have added 5 devtests. FT seems to be fine.

Under Review
2 comments Open for 3 months 18 days
Show Diffs: Show Comments: Source Commit Log
[-] /config/ConvergedContextConfig.java Open in Tab 25 Aug 2008 12:26:03 -0000 1.34 to working copy Modified
[-] /container/sim/ApplicationDispatcher.java Open in Tab 28 Aug 2008 08:50:51 -0000 1.39 to working copy Modified
[-] /container/sim/ServletDispatcher.java Open in Tab 2 Sep 2008 20:17:23 -0000 1.42 to working copy Modified
[-] /sip/DialogManager.java Open in Tab 5 Sep 2008 06:10:23 -0000 1.24 to working copy Modified
[-] /sip/Header.java Open in Tab 18 Sep 2008 12:44:42 -0000 1.20 to working copy Modified
[-] /sip/LocalStrings.properties Open in Tab 10 Sep 2008 08:49:02 -0000 1.5 to working copy Modified
[-] /sip/ParameterByteMap.java Open in Tab 13 May 2008 03:17:47 -0000 1.9 to working copy Modified
[-] /sip/SipApplicationSessionBase.java Open in Tab 12 Sep 2008 11:21:11 -0000 1.47 to working copy Modified
[-] /sip/SipServletRequestImpl.java Open in Tab 17 Sep 2008 15:42:36 -0000 1.50 to working copy Modified
[-] /sip/SipSessionImplBase.java Open in Tab 15 Sep 2008 13:15:21 -0000 1.60 to working copy Modified
[-] /sip/SipSessionsUtilImpl.java Open in Tab 13 Aug 2008 05:30:50 -0000 1.16 to working copy Modified
Crucible: Open Source License registered to Atlassian.
Atlassian Crucible, painless code review. (Version:1.6.2 Build:build-rspud1 2008-10-22) - Administration - Page generated 2009-01-09 06:15 -0600