FishEye on glassfish/appserv-core http://fisheye5.atlassian.com/browse/glassfish/ Recent changes to the "glassfish" repository under directory /appserv-core SJSAS91_FCS_BRANCH swethadn: //An extension feature for the CLB is added in the pluggable factory class Plugg... Thu, 08 Jan 2009 00:59:57 -0600 swethadn http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:swethadn:20090108065957&csize=6 http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:swethadn:20090108065957&csize=6 SJSAS91_FCS_BRANCH:swethadn:20090108065957 swethadn Thu, 08 January 2009, 00:59:57 -0600
//An extension feature for the CLB is added in the pluggable factory class PluggableFeatureFactory along with its interface(RestartExtensionFeature.java) and the implementation classes under glassfish ( RestartExtensionFeatureImpl.java) and sailfin (SipRestartExtensionFeatureImpl.java).
//These are called during the restart check and if the xpaths corresponding to the CLB commands are found , then the restart check is skipped.
Issue number: 333
Obtained from:
Submitted by:
Reviewed by: Yamini
Tests Run : Sailfin QL,
           Sailfin Cluster QL,
           Glassfish QL,
           Glassfish EE QL
/admin-core/admin/src/java/com/sun/enterprise/admin/pluggable/RestartExtensionFeature.java 1.1.2.1 (+48 -0) viewnew 
/admin-core/admin/src/java/com/sun/enterprise/admin/pluggable/RestartExtensionFeatureImpl.java 1.1.2.1 (+51 -0) viewnew 
/appserv-core/src/java/com/sun/enterprise/admin/event/ElementChangeHelper.java 1.7.2.3 (+19 -1) viewdiffs 
/appserv-core/src/java/com/sun/enterprise/admin/server/core/AdminService.java 1.31.2.8 (+9 -0) viewdiffs 
/appserv-core/src/java/com/sun/enterprise/server/pluggable/PluggableFeatureFactory.java 1.8.6.9 (+6 -0) viewdiffs 
/appserv-core/src/java/com/sun/enterprise/server/pluggable/TomcatPluggableFeatureImpl.java 1.8.6.8 (+4 -0) viewdiffs 
]]> SJSAS91_FCS_BRANCH bhavanishankar: Issue number : Sailfin issue #1538 (https://sailfin.dev.java.net/issues/show_bug... Mon, 22 Dec 2008 23:42:18 -0600 bhavanishankar http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:bhavanishankar:20081223054218&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:bhavanishankar:20081223054218&csize=1 SJSAS91_FCS_BRANCH:bhavanishankar:20081223054218 bhavanishankar Mon, 22 December 2008, 23:42:18 -0600
Issue number : Sailfin issue #1538 (https://sailfin.dev.java.net/issues/show_bug.cgi?id=1538)
Reviewed by : binod
Approved by : Srikanth Anandal
Fix details : Since all the tests are run with load-governor OFF, make it OFF by default.
Tests ran : SailFIn QL, Replication unit tests
These changes are already committed to SGES21_FCS_BRANCH, just making them available on
SJSAS91_FCS_BRANCH as well.
/appserv-core/src/java/com/sun/enterprise/web/ServerConfigLookup.java 1.21.2.16 (+1 -1) viewdiffs 
]]> SGES21_FCS_BRANCH bhavanishankar: Issue number : 1538... Mon, 22 Dec 2008 23:20:29 -0600 bhavanishankar http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:bhavanishankar:20081223052029&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:bhavanishankar:20081223052029&csize=1 SGES21_FCS_BRANCH:bhavanishankar:20081223052029 bhavanishankar Mon, 22 December 2008, 23:20:29 -0600
Issue number : 1538
Reviewed by : binod
Approved by : Srikanth Anandal
Fix details : Since all the tests are run with load-governor OFF, make it OFF by default.
Tests ran : SailFIn QL, Replication unit tests
/appserv-core/src/java/com/sun/enterprise/web/ServerConfigLookup.java 1.21.2.13.2.3 (+1 -1) viewdiffs 
]]> SGES21_FCS_BRANCH sivakumart: Issue number: 6771464... Sat, 20 Dec 2008 10:42:04 -0600 sivakumart http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:sivakumart:20081220164204&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:sivakumart:20081220164204&csize=1 SGES21_FCS_BRANCH:sivakumart:20081220164204 sivakumart Sat, 20 December 2008, 10:42:04 -0600
Issue number:  6771464
Obtained from: Tim Quinn
Submitted by:  Sivakumar Thyagarajan
Reviewed by:   -

ASClassLoaderUtil.java's getLibraries method, while converting File
objects to URL did not call toURI().toURL(). The File.toURL() method,
as the usage notes in its javadoc says,
"does not automatically escape characters that are illegal in URLs. It
is recommended that new code convert an abstract pathname into a URL by
first converting it into a URI, via the toURI method, and then
converting the URI into a URL via the URI.toURL method."
http://java.sun.com/j2se/1.4.2/docs/api/java/io/File.html#toURL()

So fixing this gets us around the issue when there are space characters
in the path.

Approved for checkin by Prasad.
Tests run: PE/EE QL against GFv2.1 and tested manually in Windows, the
deployment of a war in an installation directory with spaces.
/appserv-core/src/java/com/sun/appserv/server/util/ASClassLoaderUtil.java 1.6.2.2.4.2 (+1 -1) viewdiffs 
]]> SJSAS91_FCS_BRANCH sivakumart: Issue number: -... Sat, 20 Dec 2008 05:38:32 -0600 sivakumart http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:sivakumart:20081220113832&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:sivakumart:20081220113832&csize=1 SJSAS91_FCS_BRANCH:sivakumart:20081220113832 sivakumart Sat, 20 December 2008, 05:38:32 -0600
Issue number:  -
Obtained from: -
Submitted by:  Sivakumar Thyagarajan
Reviewed by:   -

Removing extraneous debug messages in the last checkin.
/appserv-core/src/java/com/sun/appserv/server/util/ASClassLoaderUtil.java 1.6.2.4 (+0 -3) viewdiffs 
]]> SJSAS91_FCS_BRANCH sivakumart: Issue number: 6771464... Sat, 20 Dec 2008 05:36:11 -0600 sivakumart http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:sivakumart:20081220113611&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:sivakumart:20081220113611&csize=1 SJSAS91_FCS_BRANCH:sivakumart:20081220113611 sivakumart Sat, 20 December 2008, 05:36:11 -0600
Issue number:  6771464
Obtained from: Tim Quinn
Submitted by:  Sivakumar Thyagarajan
Reviewed by:   -

ASClassLoaderUtil.java's getLibraries method, while converting File
objects to URL did not call toURI().toURL(). The File.toURL() method,
as the usage notes in its javadoc says,
"does not automatically escape characters that are illegal in URLs. It
is recommended that new code convert an abstract pathname into a URL by
first converting it into a URI, via the toURI method, and then
converting the URI into a URL via the URI.toURL method."
http://java.sun.com/j2se/1.4.2/docs/api/java/io/File.html#toURL()

So fixing this gets us around the issue when there are space characters
in the path.

Approved for checkin by Prasad.
Tests run: PE/EE QL against GFv2.1 and tested manually in Windows, the
deployment of a war in an installation directory with spaces.
/appserv-core/src/java/com/sun/appserv/server/util/ASClassLoaderUtil.java 1.6.2.3 (+4 -1) viewdiffs 
]]> SGES21_FCS_BRANCH lwhite: fix for issue https://sailfin.dev.java.net/issues/show_bug.cgi?id=1487... Thu, 18 Dec 2008 01:18:29 -0600 lwhite http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:lwhite:20081218071829&csize=9 http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:lwhite:20081218071829&csize=9 SGES21_FCS_BRANCH:lwhite:20081218071829 lwhite Thu, 18 December 2008, 01:18:29 -0600
fix for issue https://sailfin.dev.java.net/issues/show_bug.cgi?id=1487
add unicast batching - also load governor work applies here too
reviewed by: Jan Luehe, Mahesh Kannan, Joe Fialli
/appserv-core/src/java/com/sun/enterprise/web/ServerConfigLookup.java 1.21.2.13.2.2 (+23 -5) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/DynamicOwnershipManager.java 1.1.2.2.4.1 (+2 -0) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/InputPipeWrapper.java 1.8.6.10.2.1 (+128 -5) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/JxtaReplicationSender.java 1.18.2.24.2.5 (+2519 -2447) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/JxtaReplicationUnicastSender.java 1.1.4.2 (+901 -0) viewnew 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/LoadProcessingGovernor.java 1.1.4.4 (+95 -26) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationHealthChecker.java 1.9.2.18.2.5 (+1158 -1143) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationMessageRouter.java 1.8.2.19.2.2 (+30 -0) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationState.java 1.15.2.33.2.1 (+2209 -2203) viewdiffs 
]]> SJSAS91_FCS_BRANCH lwhite: fix for issue https://sailfin.dev.java.net/issues/show_bug.cgi?id=1487... Thu, 18 Dec 2008 01:07:07 -0600 lwhite http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:lwhite:20081218070707&csize=9 http://fisheye5.atlassian.com/changelog/glassfish?cs=SJSAS91_FCS_BRANCH:lwhite:20081218070707&csize=9 SJSAS91_FCS_BRANCH:lwhite:20081218070707 lwhite Thu, 18 December 2008, 01:07:07 -0600
fix for issue https://sailfin.dev.java.net/issues/show_bug.cgi?id=1487
add unicast batching - also load governor work applies here too
reviewed by: Jan Luehe, Mahesh Kannan, Joe Fialli
/appserv-core/src/java/com/sun/enterprise/web/ServerConfigLookup.java 1.21.2.15 (+23 -5) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/DynamicOwnershipManager.java 1.1.2.3 (+2 -0) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/InputPipeWrapper.java 1.8.6.11 (+128 -5) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/JxtaReplicationSender.java 1.18.2.29 (+81 -9) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/JxtaReplicationUnicastSender.java 1.1.2.1 (+901 -0) viewnew 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/LoadProcessingGovernor.java 1.1.2.3 (+95 -26) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationHealthChecker.java 1.9.2.24 (+1158 -1143) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationMessageRouter.java 1.8.2.21 (+30 -0) viewdiffs 
/appserv-core-ee/http-session-persistence/src/java/com/sun/enterprise/ee/web/sessmgmt/ReplicationState.java 1.15.2.34 (+2209 -2203) viewdiffs 
]]> SGES21_FCS_BRANCH nitkal: Issue number: 6800... Wed, 10 Dec 2008 02:21:48 -0600 nitkal http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:nitkal:20081210082148&csize=1 http://fisheye5.atlassian.com/changelog/glassfish?cs=SGES21_FCS_BRANCH:nitkal:20081210082148&csize=1 SGES21_FCS_BRANCH:nitkal:20081210082148 nitkal Wed, 10 December 2008, 02:21:48 -0600
Issue number:  6800
Obtained from:user
Submitted by: szczyp
Reviewed by:  Ron
/appserv-core/src/java/com/sun/enterprise/security/application/EJBSecurityManager.java 1.18.6.2.2.1 (+21 -11) viewdiffs 
]]>